Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Base Email template path + new test for user create #7201

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed Base Email template path + new test for user create #7201

wants to merge 4 commits into from
+34 −17

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Dec 7, 2024 •
edited
Loading

Description & Issue number it closes

It looks like the Create user fails when sending an email has an issue. This is to fix the path to sending emails
also added a new test to test create user

closes #7200

How to test the changes?

Create a new system user from a person page.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO requested a review from a team as a code owner December 7, 2024 17:55
@DawoudIO DawoudIO requested review from respencer, grayeul, DAcodedBEAT, MrClever and bigtigerku and removed request for a team December 7, 2024 17:55
@DawoudIO DawoudIO added the bug label Dec 7, 2024
@DawoudIO DawoudIO added this to the 5.13.0 milestone Dec 7, 2024
DAcodedBEAT
DAcodedBEAT requested changes Dec 9, 2024
View reviewed changes
cypress/e2e/ui/admin/admin.user.spec.js Show resolved Hide resolved
src/ChurchCRM/Emails/BaseEmail.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DAcodedBEAT DAcodedBEAT DAcodedBEAT requested changes

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

@bigtigerku bigtigerku Awaiting requested review from bigtigerku bigtigerku is a code owner automatically assigned from ChurchCRM/developers

@crossan007 crossan007 Awaiting requested review from crossan007

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.

Bug: Create User returns 500
2 participants
@DawoudIO @DAcodedBEAT